[stable26] fix(Session): avoid password confirmation on SSO #45812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
Fixed
Show fixed
Hide fixed
lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
Fixed
Show fixed
Hide fixed
lib/private/AppFramework/Middleware/Security/PasswordConfirmationMiddleware.php
Fixed
Show fixed
Hide fixed
blizzz
force-pushed
the
backport/43942/stable26
branch
from
ef675f8
to
eb1084b
Compare
artonge
approved these changes
Jun 12, 2024
ChristophWurst
approved these changes
Jun 12, 2024
SSO backends like SAML and OIDC tried a trick to suppress password confirmations as they are not possible by design. At least for SAML it was not reliable when existing user backends where used as user repositories. Now we are setting a special scope with the token, and also make sure that the scope is taken over when tokens are regenerated. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- "password-unconfirmable" is the effective name for 30, but a draft name was backported. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
4. to release
blizzz
force-pushed
the
backport/43942/stable26
branch
from
2da6020
to
06c64fd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #43942 and #45809
With same adjustments as in #45703 (comment)